Update the default style preview #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will provide my test page in the following URL: https://gist.github.com/felipecrp/46587c9d93fbf8206a7e33b5058f5ae2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that creating a document using only the
default.cssgenerates a problem with the preview, as I showed in the next figure:I updated the
default.csswith the updated code frominterface.css, available at https://gitlab.pagedmedia.org/tools/interface-polyfill. The result sounds good, except that we missed some specific tags for TOC, footnotes, chapter, etc. The next figure shows the correct pages, but without "..." on TOC:I could add the
.tocclass back to the code, but I think it would be better to keep thedefault.cssequal with theinterface.cssbecause it would make it easier for future upgrades. My suggestion is to add the specific formats to another CSS file. That way, users may choose whether they will use a custom TOC or not.I think it would be nice to have a clean
default.cssto enable other users to create their themes from scratch without worrying about pre-made styles. Another solution would be to keep the currentdefault.cssand create a newbase.csswith theinterface.csscode to enable users to design from scratch.Another drawback of the
interface.cssis that it does not fit the single-page mode when previewed in a narrow (low width/res) browser.@yihui , @cderv , and @RLesur . What do you think?
Regards,